HL-175: Delete the deprecated associateEntity and disassociateEntity actions
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty` Provider Actions
akostevich-atlassian
requested review from
Roystbeef,
stannnous and
knguyen-figma
| @@ -165,7 +165,7 @@ If needed, you could test these APIs directly by mimicking Jira backend. | |||
| "id": "${FILE_KEY}", | |||
| "ari": "NOT_USED" | |||
| }, | |||
| "associateWith": { | |||
| "associatedWith": { | |||
There was a problem hiding this comment.
note: Fixed a mistake in the documentation.
| @@ -17,17 +17,6 @@ export interface AtlassianProviderUser { | |||
| readonly id: string; | |||
| } | |||
|
|
|||
| export class AtlassianAssociation { | |||
There was a problem hiding this comment.
note: The whole concept of AtlassianAssociation has been removed from the domain of this app 🥳
CC: @stannnous
There was a problem hiding this comment.
note: This code is not related to the deprecated actions but it is not used and can be safely deleted.
stannnous
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR removes deletes the actions deprecated within #235.
Changes
associateEntityanddisassociateEntityactions.Notes
V2postfix (e.g.,entitiesRouterV2), which corresponds to the new implementation. While the PR deletes the old implementation it does not rename modules with theV2postfix to avoid extra changes and make code review simpler. If needed, please, consider removing theV2postfix in a separate PR.