AMS-26036: Update static routes to perform jwt validation #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @see https://developer.atlassian.com/cloud/jira/platform/understanding-jwt-for-connect-apps/#types-of-jwt-token | ||
| * @see https://community.developer.atlassian.com/t/action-required-atlassian-connect-vulnerability-allows-bypass-of-app-qsh-verification-via-context-jwts/47072 | ||
| */ | ||
| export const jiraQuerySymmetricJwtAuthMiddleware: RequestHandler = ( |
There was a problem hiding this comment.
nitpick (non-blocking): Consider renaming this to jiraContextSymmetricJwtFromQueryAuthMiddleware to highlight that it verifies a context symmetric JWT.
We could also name our middlewares based on their purpose instead of the token type (e.g., staticPageAuthMiddleware) but we will need to rename other middlewares as well for consistency.
akostevich-atlassian
approved these changes
Jan 29, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a ticket from atlassian's security team RE: returning <400 status for https://figma-for-jira.figma.com/static/admin and https://figma-for-jira.figma.com/static/issue-panel/issue-panel.html when passed invalid jwts
This is a non-issue since we're not doing any server-side rendering on these routes and subsequent requests do perform JWT validation.
But it doesn't hurt to validate the token before serving these static html files
Test Plan