[tests] Tweak the regex for jest unit tests to explicitly check for integration.
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a funky problem.. nice catch! |
jvrankul23
approved these changes
Oct 25, 2023
akostevich-atlassian
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex bit (?!.integration.) checks that we don't match a test like integration.test.ts.
Our copy of this repo lives under the directory
integrations/figma-for-jira. Currently, this regex inadvertently matches all tests within integrations/figma-for-jira because the folder name has the string integrationTo fix the regex, I added a check to exclude integration. vs. just the string integration.
I checked that
npm run test:unitruns both in this copy and in our copy.