Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update react monorepo to v18 (major) #1410

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(deps): update react monorepo to v18 (major) #1410

wants to merge 2 commits into from
+250 −128

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 8, 2023 •
edited

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react (source) ^17.0.2 -> ^18.2.0 age adoption passing confidence
react (source) ^17.0.1 -> ^17.0.1 || ^18.0.0 age adoption passing confidence
react-dom (source) ^17.0.2 -> ^18.2.0 age adoption passing confidence

Release Notes

facebook/react (react)

v18.2.0

Compare Source

React DOM
React DOM Server
Server Components (Experimental)

v18.1.0

Compare Source

React DOM
React DOM Server
ESLint Plugin: React Hooks
Use Subscription

v18.0.0

Compare Source

Below is a list of all new features, APIs, deprecations, and breaking changes.
Read React 18 release post and React 18 upgrade guide for more information.

New Features
React
  • useId is a new hook for generating unique IDs on both the client and server, while avoiding hydration mismatches. It is primarily useful for component libraries integrating with accessibility APIs that require unique IDs. This solves an issue that already exists in React 17 and below, but it’s even more important in React 18 because of how the new streaming server renderer delivers HTML out-of-order.
  • startTransition and useTransition let you mark some state updates as not urgent. Other state updates are considered urgent by default. React will allow urgent state updates (for example, updating a text input) to interrupt non-urgent state updates (for example, rendering a list of search results).
  • useDeferredValue lets you defer re-rendering a non-urgent part of the tree. It is similar to debouncing, but has a few advantages compared to it. There is no fixed time delay, so React will attempt the deferred render right after the first render is reflected on the screen. The deferred render is interruptible and doesn't block user input.
  • useSyncExternalStore is a new hook that allows external stores to support concurrent reads by forcing updates to the store to be synchronous. It removes the need for useEffect when implementing subscriptions to external data sources, and is recommended for any library that integrates with state external to React.
  • useInsertionEffect is a new hook that allows CSS-in-JS libraries to address performance issues of injecting styles in render. Unless you’ve already built a CSS-in-JS library we don’t expect you to ever use this. This hook will run after the DOM is mutated, but before layout effects read the new layout. This solves an issue that already exists in React 17 and below, but is even more important in React 18 because React yields to the browser during concurrent rendering, giving it a chance to recalculate layout.
React DOM Client

These new APIs are now exported from react-dom/client:

  • createRoot: New method to create a root to render or unmount. Use it instead of ReactDOM.render. New features in React 18 don't work without it.
  • hydrateRoot: New method to hydrate a server rendered application. Use it instead of ReactDOM.hydrate in conjunction with the new React DOM Server APIs. New features in React 18 don't work without it.

Both createRoot and hydrateRoot accept a new option called onRecoverableError in case you want to be notified when React recovers from errors during rendering or hydration for logging. By default, React will use reportError, or console.error in the older browsers.

React DOM Server

These new APIs are now exported from react-dom/server and have full support for streaming Suspense on the server:

  • renderToPipeableStream: for streaming in Node environments.
  • renderToReadableStream: for modern edge runtime environments, such as Deno and Cloudflare workers.

The existing renderToString method keeps working but is discouraged.

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Feb 8, 2023 •
edited

⚠ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: fixtures/parcel-transformer-test-extract-app/package-lock.json
npm WARN ignoring workspace config at /tmp/renovate/repos/github/atlassian-labs/compiled/fixtures/parcel-transformer-test-extract-app/.npmrc 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"^29.4.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^26.0.0 || ^27.0.0" from [email protected]
npm ERR! node_modules/jest-watch-typeahead
npm ERR!   dev jest-watch-typeahead@"^0.6.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_54_51_122Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_54_51_122Z-debug-0.log
File name: fixtures/parcel-transformer-test-custom-resolver-app/package-lock.json
npm WARN ignoring workspace config at /tmp/renovate/repos/github/atlassian-labs/compiled/fixtures/parcel-transformer-test-custom-resolver-app/.npmrc 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"^29.4.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^26.0.0 || ^27.0.0" from [email protected]
npm ERR! node_modules/jest-watch-typeahead
npm ERR!   dev jest-watch-typeahead@"^0.6.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_54_59_367Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_54_59_367Z-debug-0.log
File name: fixtures/parcel-transformer-test-custom-resolve-app/package-lock.json
npm WARN ignoring workspace config at /tmp/renovate/repos/github/atlassian-labs/compiled/fixtures/parcel-transformer-test-custom-resolve-app/.npmrc 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"^29.4.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^26.0.0 || ^27.0.0" from [email protected]
npm ERR! node_modules/jest-watch-typeahead
npm ERR!   dev jest-watch-typeahead@"^0.6.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_04_890Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_04_890Z-debug-0.log
File name: fixtures/parcel-transformer-test-compress-class-name-app/package-lock.json
npm WARN ignoring workspace config at /tmp/renovate/repos/github/atlassian-labs/compiled/fixtures/parcel-transformer-test-compress-class-name-app/.npmrc 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"^29.4.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^26.0.0 || ^27.0.0" from [email protected]
npm ERR! node_modules/jest-watch-typeahead
npm ERR!   dev jest-watch-typeahead@"^0.6.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_08_842Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_08_842Z-debug-0.log
File name: fixtures/parcel-optimizer-test-app/package-lock.json
npm WARN ignoring workspace config at /tmp/renovate/repos/github/atlassian-labs/compiled/fixtures/parcel-optimizer-test-app/.npmrc 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"^29.4.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^26.0.0 || ^27.0.0" from [email protected]
npm ERR! node_modules/jest-watch-typeahead
npm ERR!   dev jest-watch-typeahead@"^0.6.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_12_787Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_12_787Z-debug-0.log
File name: examples/parcel/package-lock.json
npm WARN ignoring workspace config at /tmp/renovate/repos/github/atlassian-labs/compiled/examples/parcel/.npmrc 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"^29.4.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^26.0.0 || ^27.0.0" from [email protected]
npm ERR! node_modules/jest-watch-typeahead
npm ERR!   dev jest-watch-typeahead@"^0.6.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_16_658Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-12-29T04_55_16_658Z-debug-0.log

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023 •
edited

⚠️ No Changeset found

Latest commit: 8df39b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dddlr
Copy link
Collaborator

dddlr commented Feb 8, 2023 •
edited

Blocked by webpack version update (the version of @storybook/builder-webpack5 currently used in repo doesn't support react v18, needs to be updated first)

edit: no longer blocked (#1411)

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from d636873 to e249c6d Compare February 8, 2023 10:34
@dddlr dddlr mentioned this pull request Feb 9, 2023
Open
1 task
@dddlr dddlr self-assigned this Feb 9, 2023
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 9 times, most recently from b96ca56 to bb1d089 Compare February 13, 2023 10:34
@dddlr dddlr removed their assignment Feb 13, 2023
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 7 times, most recently from 1387942 to 2d9d546 Compare February 21, 2023 06:36
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 4 times, most recently from a4c6c20 to 583b6be Compare March 6, 2023 05:31
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from fc519d6 to f59997f Compare March 14, 2023 03:49
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from f59997f to c5e08bb Compare March 28, 2023 05:27
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 10 times, most recently from f3a08e3 to 206b2a9 Compare December 12, 2023 21:25
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 10 times, most recently from 80f8f14 to 151c53d Compare December 22, 2023 03:27
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 151c53d to b62cb40 Compare December 29, 2023 04:55
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Dec 29, 2023 •
edited

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@dddlr
Copy link
Collaborator

dddlr commented Dec 29, 2023 •
edited

  • Fix typechecking issues in packages/react/src/runtime/__tests__/style.test.tsx
  • Fix @compiled/webpack-loader tests hanging

Estimated time: a few days to a week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeLane JakeLane Awaiting requested review from JakeLane JakeLane is a code owner

@pancaspe87 pancaspe87 Awaiting requested review from pancaspe87 pancaspe87 is a code owner

@liamqma liamqma Awaiting requested review from liamqma liamqma is a code owner

@dddlr dddlr Awaiting requested review from dddlr dddlr is a code owner

@zerosicx zerosicx Awaiting requested review from zerosicx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dddlr