-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parser will throw an error when address is null/no param but param is present #1011
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Quality Gate passedIssues Measures |
parameter
is null or param.length === 0
@ibishal the Spectral rule should apply for AsyncAPI spec v3. Not necessary for v2 (unless no cost of adding) |
FYI @ibishal, this PR is part of #1019 and by that, part of this Bounty Program issue. If you want to participate in the Bounty Program and get a reward ($), please express your interest in #1016 and include an outline of the work you will do for each of the rules that should be added. |
i had created this PR solving the issue #875 (it is overlapping with issue #1019 ), should i close this ?
i have sent a basic outline in slack(dms), should i put it in the issue too(more briefly outlining each rules) |
One is a bug, the other is the issue that mentions to work on such a bugfix as part of the bounty program.
You should follow standard procedures. Express your desire of working on such an issue, say how would you do with each of the tasks that are part of the bounty issue and not only with one. I will choose the right person based on that info. |
Are you gonna include the rule for v3? |
Of course, you can work in any of the issues you want, that doesn't mean it is assigned to you. We only assign issues in programs such as Bounty, GSoC, etc. Meaning other people is also free to work in the same one and send a PR in parallel. |
@smoya this PR is ready for review |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
Now when there is
parameter
but the address not contain any, then it will throw an errorRelated issue(s)
Fixes #875