-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #2114 - add required field management in csharp newtonsoft serializer #2117
base: master
Are you sure you want to change the base?
feat: #2114 - add required field management in csharp newtonsoft serializer #2117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to continue with enforceRequired
or make it part of the default rendering process?
All you need to make the changes on the next
branch instead of master
, but up to you 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
** Still need to review 😄
Pull Request Test Coverage Report for Build 11572166800Details
💛 - Coveralls |
Ah damn, I missed the part for the 'next' branch sorry. |
Description
When generating c# model with newtonsoft serialization, an option now allows to prevent deserialization if required fields are missing
Related Issue
#2114
Checklist
npm run lint
).npm run test
).Additional Notes