Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create new command to format the asyncapi document #1573

Merged
merged 13 commits into from
Nov 22, 2024
Merged

feat: create new command to format the asyncapi document #1573

merged 13 commits into from
Nov 22, 2024
+222 −18,153

Conversation

AayushSaini101
Copy link
Contributor

@AayushSaini101 AayushSaini101 commented Nov 14, 2024 •
edited
Loading

Closes: #1419
Related: #1508

  • Added new command to format the Asyncapi document [ Done ] [ json, yaml support ]
  • Test cases to verify the command [ Done Added test cases]

@AayushSaini101 AayushSaini101 marked this pull request as draft November 14, 2024 05:04
@AayushSaini101
Copy link
Contributor Author

@Souvikns a new command has already introduced #1549 via this MR, that is asyncapi format that change one format to another format. I think we can use asyncapi pretty <asyncapi.yml> command to format the asyncapi document

@AayushSaini101 AayushSaini101 marked this pull request as ready for review November 19, 2024 11:50
@AayushSaini101
Copy link
Contributor Author

Before pretty:
Screenshot 2024-11-19 at 5 52 05 PM
After running the pretty command:
Screenshot 2024-11-19 at 5 52 38 PM
Running the new command locally, beautifying in-place
Screenshot 2024-11-19 at 5 53 53 PM

@catosaurusrex2003
Copy link
Contributor

Thanks for the name change @AayushSaini101

Is adding a JSON AsyncAPI document prettifier also within the scope of this pr?

@AayushSaini101
Copy link
Contributor Author

Thanks for the name change @AayushSaini101

Is adding a JSON AsyncAPI document prettifier also within the scope of this pr?

Added json support also @catosaurusrex2003 thanks : )

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Souvikns
Souvikns approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AayushSaini101
Copy link
Contributor Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 6b866c4 into asyncapi:master Nov 22, 2024
22 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souvikns Souvikns Souvikns approved these changes

@Amzani Amzani Awaiting requested review from Amzani Amzani is a code owner

@Shurtu-gal Shurtu-gal Awaiting requested review from Shurtu-gal Shurtu-gal is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
CLI - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] New Command to format the Asyncapi document [ Mentorship Project Part 2 ]
4 participants
@AayushSaini101 @catosaurusrex2003 @asyncapi-bot @Souvikns