-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replicate incorrect bundling and missing assertions part of #1323 #1389
Open
francocm
wants to merge
17
commits into
asyncapi:master
Choose a base branch
from
francocm:fix/1323/bundleNotBundlingExternalFiles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+220
−34
Open
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b432838
test: replicate incorrect bundling and missing assertions part of #1323
francocm 03ce3a6
Updated assertion styles as per PR feedback as part of https://github…
francocm e719f24
Fixed incorrect test and incorrect expected files as part of https://…
francocm c8564ad
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
francocm d1c5c19
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
francocm 1becec0
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
francocm d4296c5
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
francocm 104affb
As per issue raised in https://github.com/APIDevTools/json-schema-ref…
francocm 3bcdee9
Moved back to validateGeneratedSpec with explicit expects as per PR c…
francocm 8efa7cf
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot c06a4d4
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot c761c8c
lint fix
francocm 1fa8a93
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot 523b5f2
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot bb0c1fd
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot 041f834
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot 3fcec67
Merge branch 'master' into fix/1323/bundleNotBundlingExternalFiles
asyncapi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
asyncapi: 2.6.0 | ||
info: | ||
title: Account Service | ||
version: 1.0.0 | ||
description: This service is in charge of processing user signups | ||
channels: | ||
user/signedup: | ||
subscribe: | ||
message: | ||
payload: | ||
type: object | ||
properties: | ||
displayName: | ||
type: string | ||
description: Name of the user | ||
email: | ||
type: string | ||
format: email | ||
description: Email of the user | ||
x-origin: ./test/integration/bundle/messages.yaml#/messages/UserSignedUp | ||
user/loggedOut: | ||
subscribe: | ||
message: | ||
payload: | ||
type: object | ||
properties: | ||
displayName: | ||
type: string | ||
description: Name of the user | ||
userId: | ||
type: string | ||
description: Id the user | ||
timestamp: | ||
type: number | ||
description: Time stamp when the user logged out | ||
x-origin: ./test/integration/bundle/messages.yaml#/messages/UserLoggedOut |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
test/integration/bundle/final-asyncapiv3-with-xorigin.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
asyncapi: 3.0.0 | ||
info: | ||
title: Example Service | ||
version: 1.0.0 | ||
description: Example Service. | ||
channels: | ||
commentLikedChannel: | ||
address: comment/liked | ||
x-origin: ./test/integration/bundle/channels.yaml#/channels/commentLikedChannel | ||
userSignedup: | ||
address: user/signedup | ||
messages: | ||
userSignedUpMessage: | ||
payload: | ||
type: object | ||
properties: | ||
displayName: | ||
type: string | ||
description: Name of the user | ||
email: | ||
type: string | ||
format: email | ||
description: Email of the user | ||
x-origin: ./test/integration/bundle/messages.yaml#/messages/UserSignedUp | ||
test: | ||
address: /test | ||
messages: | ||
testMessage: | ||
payload: | ||
type: string | ||
x-origin: '#/components/messages/TestMessage' | ||
operations: | ||
UserSignedUp: | ||
action: send | ||
channel: | ||
$ref: '#/channels/userSignedup' | ||
messages: | ||
- $ref: '#/channels/userSignedup/messages/userSignedUpMessage' | ||
TestOpp: | ||
action: send | ||
channel: | ||
$ref: '#/channels/test' | ||
messages: | ||
- $ref: '#/channels/test/messages/testMessage' | ||
components: | ||
messages: | ||
TestMessage: | ||
payload: | ||
type: string | ||
x-origin: '#/components/messages/TestMessage' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
asyncapi: 3.0.0 | ||
info: | ||
title: Example Service | ||
version: 1.0.0 | ||
description: Example Service. | ||
channels: | ||
commentLikedChannel: | ||
address: comment/liked | ||
userSignedup: | ||
address: user/signedup | ||
messages: | ||
userSignedUpMessage: | ||
payload: | ||
type: object | ||
properties: | ||
displayName: | ||
type: string | ||
description: Name of the user | ||
email: | ||
type: string | ||
format: email | ||
description: Email of the user | ||
test: | ||
address: /test | ||
messages: | ||
testMessage: | ||
payload: | ||
type: string | ||
operations: | ||
UserSignedUp: | ||
action: send | ||
channel: | ||
$ref: '#/channels/userSignedup' | ||
messages: | ||
- $ref: '#/channels/userSignedup/messages/userSignedUpMessage' | ||
TestOpp: | ||
action: send | ||
channel: | ||
$ref: '#/channels/test' | ||
messages: | ||
- $ref: '#/channels/test/messages/testMessage' | ||
components: | ||
messages: | ||
TestMessage: | ||
payload: | ||
type: string |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francocm could you add the spec files in test/fixtures as can be seen for others.