Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKitGTK is a nightmare to build on macOS. It takes hours to compile (literally), it needs patches, and it doubles up functionality that is already available on the platform.
Hence, it would seem tempting to try to use the native WebKit that ships with the macOS platform. This is what this PR attempts.
I plan to do this in two steps:
Move anything specific to WebKitGTK from the header to the corresponding implementation file using the C++ PIMPL pattern. If everything works ok, this should produce an executable that works identically to before the refactoring.
WKWebView
on macOS.As all the public class interfaces have been freed from WebKitGtk references in the previous phase, I can start adding macOS-specific class implementations, that implement the public class interface (using ObjC++), but use a native
WKWebView
. Whether these new files, or the "standard" ones for Linux are compiled will be determined by theCMakeLists.txt
build specs.A key challenge will of course be to hook the
WKWebView
into the hierarchy of Gtk graphics objects. For sure, somewhere deep down the Gtk implementation there must be a pointer or reference to some macOS native window or similar. Perhaps I can find a way to access that, and hook theWKWebView
up with that. Fingers crossed! 🤞