WIP: fix #317: allow editing the message once it gets available in the db …

[gauteh]

…after sending

Fixes #317.

Since a full thread object isn't set up for the ThreadView there might be some ways to break this, please try. Also, hopefully all functionality which should be off after sending is now off.. (in particular deleting attachments seem to maybe be possible?)

@mxmehl Please take a look.

TODO:

• drop EditMessage signal sink after first call
• updating messages which have not been saved (but are alter added) does not work since we dont have thread id: connect directly to message id?

Related #581

[mxmehl]

Thanks a lot, seems to work in principle! But I detected a few bugs:

• I can only tag the message once with l. If I wanted to add another tag or fix a typo, I can't do so anymore.
• If I want to remove a tag manually by opening the message in another thread, astroid crashes. Log: http://s.mehl.mx/aXZfr

[hughwilliams94]

Is there anything preventing these changes from being merged? Do you need more bug testing?

EDIT: I have just downloaded and built this branch, but I don't see any difference in behaviour. I cannot tag in the new message window, I have to save a draft, tag that draft and then send it.

[gauteh]

I think there was a crash that needed fixing. ons. 24. apr. 2019 kl. 11:11 skrev Hugh Williams <[email protected]>:

…

Is there anything preventing these changes from being merged? Do you need more bug testing? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#583 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAN367SVFCEESGJYV3MIULPSAP4PANCNFSM4F6J6X3A> .

[hughwilliams94]

I don't seem to get any crashes but I can't tag from the new message window, pressing l or + does nothing.