Update pep508_rs and pep440_rs #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is in an attempt to solve #912. In this case by using the real absolute path as the Url part of VerbatimUrl and the ${PROJECT_ROOT}/../relative path as the "given" part of the URL, let's see how that works out. Remains to be done
|
bluss
force-pushed
the
update-pep508
branch
5 times, most recently
from
33aa30d
to
81ac63f
Compare
bluss
commented
Mar 23, 2024
bluss
force-pushed
the
update-pep508
branch
2 times, most recently
from
69a8d4a
to
1d89d54
Compare
|
Now it's working, but it certainly does not feel solid around VerbatimUrl and ${}'s. |
bluss
force-pushed
the
update-pep508
branch
6 times, most recently
from
2ce0036
to
fc91d87
Compare
Merged
|
rebased x3 |
|
Feedback on this is welcome. Updating these crates is ok? Fixing relative paths is ok or a bad idea? We could go other ways, like adopting another convention for relative paths than the |
Update pep508_rs and pep440_rs crates Main reason is to use VerbatimUrl from pep508_rs. Note that monotrail-utils is still using the older pep508_rs.
For test uniformity, set author name in test config.
This is to explicitly use / for path separators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pep508_rs and pep440_rs crates
Main reason is to use VerbatimUrl from pep508_rs and try to fix issues around file:///${PROJECT_ROOT}/etc dependencies.
Note that monotrail-utils is still using the older pep508_rs.
Fixes #912