Upgrade annotation snippet #11618
Closed
Upgrade annotation snippet #11618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
commented
May 30, 2024
| test.py:1:5: Q000 [*] Double quotes found but single quotes preferred | ||
| test.py:1:5: B005 Using `.strip()` with multi-character strings is misleading | ||
| test.py:1:19: Q000 [*] Double quotes found but single quotes preferred | ||
| error[Q000]: test.py:1:5: [*] Double quotes found but single quotes preferred |
There was a problem hiding this comment.
It's not clear to me where and how we want to show the file name, location, and fixability
MichaReiser
force-pushed
the
upgrade-annotation-snippet
branch
from
78c9eb0 to
c923ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried in this PR to upgrade annotation snippet but I hit a blocker because annotation snippet has now become more opinionated. It now prefixes every message with a level and requires a title.
That means, it is no longer possible to have our custom message headers of the form
path:row:column [CODE] messageand instead it must beerror[code]: <title>and it is unclear what message format we want.TODO:
groupedemitterTest Plan
See updated snapshots
Fixes #10832