ruff server
: Support noqa
comment code action
#11276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10594.
Code actions to disable a diagnostic via
noqa
comment are now available.noqa.mp4
DiagnosticFix
has been changed so thatnoqa
code actions appear even for diagnostics with no available quick fix. It can contain quick fix edits,noqa
comment edits, or both.Test Plan
The scenarios that need to be tested are as follows:
noqa
comment.noqa
comment manually should make a diagnostic disappearFix all auto-fixable problems
should not addnoqa
commentsnoqa
comment should make the diagnostic re-appear