Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyupgrade] Show violations without auto-fix for UP031 #11229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented May 1, 2024

Summary

This shows violations of the UP031 rule which can't be auto-fixed, so that they can be fixed manually (similar to the pylint consider-using-f-strings rule)

Test Plan

Updated fixtures.

Copy link
Contributor

github-actions bot commented May 1, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+1140 -1002 violations, +0 -0 fixes in 10 projects; 34 projects unchanged)

bokeh/bokeh (+72 -63 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

- examples/interaction/js_callbacks/customjs_for_hover.py:37:8: UP031 Use format specifiers instead of percent format
+ examples/interaction/js_callbacks/customjs_for_hover.py:37:8: UP031 Use format specifiers or f-strings instead of percent format
- examples/models/trail.py:73:23: UP031 Use format specifiers instead of percent format
+ examples/models/trail.py:73:23: UP031 Use format specifiers or f-strings instead of percent format
- examples/models/trail.py:92:23: UP031 Use format specifiers instead of percent format
+ examples/models/trail.py:92:23: UP031 Use format specifiers or f-strings instead of percent format
+ examples/models/widgets.py:84:37: UP031 Use format specifiers or f-strings instead of percent format
+ examples/models/widgets.py:86:37: UP031 Use format specifiers or f-strings instead of percent format
- examples/server/app/server_auth/app.py:56:50: UP031 Use format specifiers instead of percent format
+ examples/server/app/server_auth/app.py:56:50: UP031 Use format specifiers or f-strings instead of percent format
... 125 additional changes omitted for project

demisto/content (+725 -675 violations, +0 -0 fixes)

- Packs/ARIAPacketIntelligence/Integrations/ARIAPacketIntelligence/ARIAPacketIntelligence.py:2297:9: UP031 Use format specifiers instead of percent format
+ Packs/ARIAPacketIntelligence/Integrations/ARIAPacketIntelligence/ARIAPacketIntelligence.py:2297:9: UP031 Use format specifiers or f-strings instead of percent format
- Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:21:27: UP031 Use format specifiers instead of percent format
+ Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:21:27: UP031 Use format specifiers or f-strings instead of percent format
- Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:37:27: UP031 Use format specifiers instead of percent format
+ Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:37:27: UP031 Use format specifiers or f-strings instead of percent format
- Packs/AWS-Lambda/Integrations/AWS_Lambda/AWS_Lambda.py:97:27: UP031 Use format specifiers instead of percent format
+ Packs/AWS-Lambda/Integrations/AWS_Lambda/AWS_Lambda.py:97:27: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Accessdata/Integrations/Accessdata/Accessdata.py:380:9: UP031 Use format specifiers instead of percent format
+ Packs/Accessdata/Integrations/Accessdata/Accessdata.py:380:9: UP031 Use format specifiers or f-strings instead of percent format
- Packs/ActiveMQ/Integrations/ActiveMQ/ActiveMQ.py:25:25: UP031 Use format specifiers instead of percent format
+ Packs/ActiveMQ/Integrations/ActiveMQ/ActiveMQ.py:25:25: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:143:24: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:143:24: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:173:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:173:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:176:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:176:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:186:23: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:186:23: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:190:23: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:190:23: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:100:24: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:100:24: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:103:24: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:103:24: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:133:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:133:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:136:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:136:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:146:23: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:146:23: UP031 Use format specifiers or f-strings instead of percent format
... 1368 additional changes omitted for project

docker/docker-py (+1 -1 violations, +0 -0 fixes)

- docker/utils/ports.py:41:22: UP031 Use format specifiers instead of percent format
+ docker/utils/ports.py:41:22: UP031 Use format specifiers or f-strings instead of percent format

freedomofpress/securedrop (+132 -120 violations, +0 -0 fixes)

- securedrop/models.py:201:16: UP031 Use format specifiers instead of percent format
+ securedrop/models.py:201:16: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/models.py:299:16: UP031 Use format specifiers instead of percent format
+ securedrop/models.py:299:16: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/models.py:94:16: UP031 Use format specifiers instead of percent format
+ securedrop/models.py:94:16: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/pretty_bad_protocol/_logger.py:66:14: UP031 Use format specifiers instead of percent format
+ securedrop/pretty_bad_protocol/_logger.py:66:14: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/pretty_bad_protocol/_meta.py:1000:29: UP031 Use format specifiers instead of percent format
+ securedrop/pretty_bad_protocol/_meta.py:1000:29: UP031 Use format specifiers or f-strings instead of percent format
... 242 additional changes omitted for project

ibis-project/ibis (+5 -0 violations, +0 -0 fixes)

+ ibis/backends/impala/tests/test_exprs.py:135:29: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/backends/impala/tests/test_exprs.py:421:29: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/backends/impala/tests/test_exprs.py:477:26: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/backends/impala/tests/test_exprs.py:514:29: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/tests/expr/test_window_functions.py:41:24: UP031 Use format specifiers or f-strings instead of percent format

mlflow/mlflow (+36 -33 violations, +0 -0 fixes)

- examples/pytorch/CaptumExample/Titanic_Captum_Interpret.py:133:39: UP031 Use format specifiers instead of percent format
+ examples/pytorch/CaptumExample/Titanic_Captum_Interpret.py:133:39: UP031 Use format specifiers or f-strings instead of percent format
- examples/pytorch/mnist_tensorboard_artifact.py:218:9: UP031 Use format specifiers instead of percent format
+ examples/pytorch/mnist_tensorboard_artifact.py:218:9: UP031 Use format specifiers or f-strings instead of percent format
- examples/pytorch/mnist_tensorboard_artifact.py:226:9: UP031 Use format specifiers instead of percent format
+ examples/pytorch/mnist_tensorboard_artifact.py:226:9: UP031 Use format specifiers or f-strings instead of percent format
- examples/rapids/mlflow_project/notebooks/rapids_mlflow.ipynb:cell 13:44:18: UP031 Use format specifiers instead of percent format
+ examples/rapids/mlflow_project/notebooks/rapids_mlflow.ipynb:cell 13:44:18: UP031 Use format specifiers or f-strings instead of percent format
- examples/sklearn_elasticnet_wine/train.ipynb:cell 2:66:15: UP031 Use format specifiers instead of percent format
+ examples/sklearn_elasticnet_wine/train.ipynb:cell 2:66:15: UP031 Use format specifiers or f-strings instead of percent format
... 59 additional changes omitted for project

python/mypy (+139 -82 violations, +0 -0 fixes)

- misc/dump-ast.py:42:34: UP031 Use format specifiers instead of percent format
+ misc/dump-ast.py:42:34: UP031 Use format specifiers or f-strings instead of percent format
- misc/gen_blog_post_html.py:31:26: UP031 Use format specifiers instead of percent format
+ misc/gen_blog_post_html.py:31:26: UP031 Use format specifiers or f-strings instead of percent format
+ misc/incremental_checker.py:358:15: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:1176:36: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:279:13: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:2975:24: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:3215:17: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:3243:25: UP031 Use format specifiers or f-strings instead of percent format
... 211 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
UP031 2142 1140 1002 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1140 -1002 violations, +0 -0 fixes in 10 projects; 34 projects unchanged)

bokeh/bokeh (+72 -63 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- examples/interaction/js_callbacks/customjs_for_hover.py:37:8: UP031 Use format specifiers instead of percent format
+ examples/interaction/js_callbacks/customjs_for_hover.py:37:8: UP031 Use format specifiers or f-strings instead of percent format
- examples/models/trail.py:73:23: UP031 Use format specifiers instead of percent format
+ examples/models/trail.py:73:23: UP031 Use format specifiers or f-strings instead of percent format
- examples/models/trail.py:92:23: UP031 Use format specifiers instead of percent format
+ examples/models/trail.py:92:23: UP031 Use format specifiers or f-strings instead of percent format
+ examples/models/widgets.py:84:37: UP031 Use format specifiers or f-strings instead of percent format
+ examples/models/widgets.py:86:37: UP031 Use format specifiers or f-strings instead of percent format
- examples/server/app/server_auth/app.py:56:50: UP031 Use format specifiers instead of percent format
+ examples/server/app/server_auth/app.py:56:50: UP031 Use format specifiers or f-strings instead of percent format
... 125 additional changes omitted for project

demisto/content (+725 -675 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- Packs/ARIAPacketIntelligence/Integrations/ARIAPacketIntelligence/ARIAPacketIntelligence.py:2297:9: UP031 Use format specifiers instead of percent format
+ Packs/ARIAPacketIntelligence/Integrations/ARIAPacketIntelligence/ARIAPacketIntelligence.py:2297:9: UP031 Use format specifiers or f-strings instead of percent format
- Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:21:27: UP031 Use format specifiers instead of percent format
+ Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:21:27: UP031 Use format specifiers or f-strings instead of percent format
- Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:37:27: UP031 Use format specifiers instead of percent format
+ Packs/AWS-ACM/Integrations/AWS-ACM/AWS-ACM.py:37:27: UP031 Use format specifiers or f-strings instead of percent format
- Packs/AWS-Lambda/Integrations/AWS_Lambda/AWS_Lambda.py:97:27: UP031 Use format specifiers instead of percent format
+ Packs/AWS-Lambda/Integrations/AWS_Lambda/AWS_Lambda.py:97:27: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Accessdata/Integrations/Accessdata/Accessdata.py:380:9: UP031 Use format specifiers instead of percent format
+ Packs/Accessdata/Integrations/Accessdata/Accessdata.py:380:9: UP031 Use format specifiers or f-strings instead of percent format
- Packs/ActiveMQ/Integrations/ActiveMQ/ActiveMQ.py:25:25: UP031 Use format specifiers instead of percent format
+ Packs/ActiveMQ/Integrations/ActiveMQ/ActiveMQ.py:25:25: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:143:24: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:143:24: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:173:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:173:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:176:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:176:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:186:23: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:186:23: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:190:23: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/ACME/ACME.py:190:23: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:100:24: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:100:24: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:103:24: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:103:24: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:133:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:133:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:136:40: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:136:40: UP031 Use format specifiers or f-strings instead of percent format
- Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:146:23: UP031 Use format specifiers instead of percent format
+ Packs/Ansible_Powered_Integrations/Integrations/AlibabaCloud/AlibabaCloud.py:146:23: UP031 Use format specifiers or f-strings instead of percent format
... 1368 additional changes omitted for project

docker/docker-py (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- docker/utils/ports.py:41:22: UP031 Use format specifiers instead of percent format
+ docker/utils/ports.py:41:22: UP031 Use format specifiers or f-strings instead of percent format

freedomofpress/securedrop (+132 -120 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- securedrop/models.py:201:16: UP031 Use format specifiers instead of percent format
+ securedrop/models.py:201:16: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/models.py:299:16: UP031 Use format specifiers instead of percent format
+ securedrop/models.py:299:16: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/models.py:94:16: UP031 Use format specifiers instead of percent format
+ securedrop/models.py:94:16: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/pretty_bad_protocol/_logger.py:66:14: UP031 Use format specifiers instead of percent format
+ securedrop/pretty_bad_protocol/_logger.py:66:14: UP031 Use format specifiers or f-strings instead of percent format
- securedrop/pretty_bad_protocol/_meta.py:1000:29: UP031 Use format specifiers instead of percent format
+ securedrop/pretty_bad_protocol/_meta.py:1000:29: UP031 Use format specifiers or f-strings instead of percent format
... 242 additional changes omitted for project

ibis-project/ibis (+5 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ ibis/backends/impala/tests/test_exprs.py:135:29: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/backends/impala/tests/test_exprs.py:421:29: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/backends/impala/tests/test_exprs.py:477:26: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/backends/impala/tests/test_exprs.py:514:29: UP031 Use format specifiers or f-strings instead of percent format
+ ibis/tests/expr/test_window_functions.py:41:24: UP031 Use format specifiers or f-strings instead of percent format

mlflow/mlflow (+36 -33 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- examples/pytorch/CaptumExample/Titanic_Captum_Interpret.py:133:39: UP031 Use format specifiers instead of percent format
+ examples/pytorch/CaptumExample/Titanic_Captum_Interpret.py:133:39: UP031 Use format specifiers or f-strings instead of percent format
- examples/pytorch/mnist_tensorboard_artifact.py:218:9: UP031 Use format specifiers instead of percent format
+ examples/pytorch/mnist_tensorboard_artifact.py:218:9: UP031 Use format specifiers or f-strings instead of percent format
- examples/pytorch/mnist_tensorboard_artifact.py:226:9: UP031 Use format specifiers instead of percent format
+ examples/pytorch/mnist_tensorboard_artifact.py:226:9: UP031 Use format specifiers or f-strings instead of percent format
- examples/rapids/mlflow_project/notebooks/rapids_mlflow.ipynb:cell 13:44:18: UP031 Use format specifiers instead of percent format
+ examples/rapids/mlflow_project/notebooks/rapids_mlflow.ipynb:cell 13:44:18: UP031 Use format specifiers or f-strings instead of percent format
- examples/sklearn_elasticnet_wine/train.ipynb:cell 2:66:15: UP031 Use format specifiers instead of percent format
+ examples/sklearn_elasticnet_wine/train.ipynb:cell 2:66:15: UP031 Use format specifiers or f-strings instead of percent format
... 59 additional changes omitted for project

python/mypy (+139 -82 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- misc/dump-ast.py:42:34: UP031 Use format specifiers instead of percent format
+ misc/dump-ast.py:42:34: UP031 Use format specifiers or f-strings instead of percent format
- misc/gen_blog_post_html.py:31:26: UP031 Use format specifiers instead of percent format
+ misc/gen_blog_post_html.py:31:26: UP031 Use format specifiers or f-strings instead of percent format
+ misc/incremental_checker.py:358:15: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:1176:36: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:279:13: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:2975:24: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:3215:17: UP031 Use format specifiers or f-strings instead of percent format
+ mypy/build.py:3243:25: UP031 Use format specifiers or f-strings instead of percent format
... 211 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
UP031 2142 1140 1002 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant