Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update annotate-snippets to 0.11.0 #10832

Open
MichaReiser opened this issue Apr 8, 2024 · 2 comments · May be fixed by #15359
Open

Update annotate-snippets to 0.11.0 #10832

MichaReiser opened this issue Apr 8, 2024 · 2 comments · May be fixed by #15359
Labels
dependencies Pull requests that update a dependency file
Milestone
v0.10

Comments

@MichaReiser
Copy link
Member

See #10699

CC: @carljm in case you plan to work on this.

We may also decide not to use annotate-snippets anymore (it has some weirdness like it supports some markup that can mess up rendering)
@MichaReiser MichaReiser added help wanted Contributions especially welcome dependencies Pull requests that update a dependency file labels Apr 8, 2024
@dhruvmanila
Copy link
Member

This will be useful for the new parser test cases as well. If I understand this correctly, rust-lang/annotate-snippets-rs#107 allows highlighting empty spans which can occur at EOF. You might've noticed that there are no error messages in some of the cases :)

@MichaReiser
Copy link
Member Author

MichaReiser commented Apr 8, 2024 •
edited
Loading

Oh nice, that annoyed me for a long time. I think we should also change the expected errors to point to an empty range that starts at the next token's position instead of using the entire range of the next token.

@MichaReiser MichaReiser removed the help wanted Contributions especially welcome label Jul 4, 2024
@MichaReiser MichaReiser mentioned this issue Jul 4, 2024
Closed
@MichaReiser MichaReiser mentioned this issue Sep 23, 2024
Merged
1 task
@AlexWaygood AlexWaygood added this to the v0.8 milestone Oct 8, 2024
@AlexWaygood AlexWaygood modified the milestones: v0.8, v0.9 Nov 18, 2024
@MichaReiser MichaReiser modified the milestones: v0.9, v.0.10 Jan 8, 2025
@BurntSushi BurntSushi linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.10
3 participants
@MichaReiser @AlexWaygood @dhruvmanila