Add row_stack to NumPy 2.0 migration rule (#10646)

Hi! I left out one of the functions in the migration rule which became deprecated/removed in NumPy 2.0 (numpy/numpy#26032 (comment)). cc @anntzer
astral-sh · Mar 28, 2024 · a0263ab · a0263ab
1 parent 6b580c1
commit a0263ab
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/numpy/NPY201.py b/crates/ruff_linter/resources/test/fixtures/numpy/NPY201.py
@@ -104,3 +104,5 @@ def func():
     np.unicode_("asf")
 
     np.who()
+
+    np.row_stack(([1,2], [3,4]))
diff --git a/crates/ruff_linter/src/rules/numpy/rules/numpy_2_0_deprecation.rs b/crates/ruff_linter/src/rules/numpy/rules/numpy_2_0_deprecation.rs
@@ -522,6 +522,14 @@ pub(crate) fn numpy_2_0_deprecation(checker: &mut Checker, expr: &Expr) {
                     guideline: Some("Use an IDE variable explorer or `locals()` instead."),
                 },
             }),
+            ["numpy", "row_stack"] => Some(Replacement {
+                existing: "row_stack",
+                details: Details::AutoImport {
+                    path: "numpy",
+                    name: "vstack",
+                    compatibility: Compatibility::BackwardsCompatible,
+                },
+            }),
             _ => None,
         });
 

diff --git a/...rules/numpy/snapshots/ruff_linter__rules__numpy__tests__numpy2-deprecation_NPY201.py.snap b/...rules/numpy/snapshots/ruff_linter__rules__numpy__tests__numpy2-deprecation_NPY201.py.snap
@@ -836,13 +836,32 @@ NPY201.py:104:5: NPY201 [*] `np.unicode_` will be removed in NumPy 2.0. Use `num
     104 |+    np.str_("asf")
 105 105 | 
 106 106 |     np.who()
+107 107 | 
 
 NPY201.py:106:5: NPY201 `np.who` will be removed in NumPy 2.0. Use an IDE variable explorer or `locals()` instead.
     |
 104 |     np.unicode_("asf")
 105 | 
 106 |     np.who()
     |     ^^^^^^ NPY201
+107 | 
+108 |     np.row_stack(([1,2], [3,4]))
     |
 
+NPY201.py:108:5: NPY201 [*] `np.row_stack` will be removed in NumPy 2.0. Use `numpy.vstack` instead.
+    |
+106 |     np.who()
+107 | 
+108 |     np.row_stack(([1,2], [3,4]))
+    |     ^^^^^^^^^^^^ NPY201
+    |
+    = help: Replace with `numpy.vstack`
+
+ℹ Safe fix
+105 105 | 
+106 106 |     np.who()
+107 107 | 
+108     |-    np.row_stack(([1,2], [3,4]))
+    108 |+    np.vstack(([1,2], [3,4]))
+
Original file line number	Diff line number	Diff line change
Expand Up		@@ -104,3 +104,5 @@ def func():
		np.unicode_("asf")

		np.who()

		np.row_stack(([1,2], [3,4]))