[ruff] Fix false positive on global keyword (RUF052)

astral-sh · Jan 3, 2025 · 70f2f89 · 70f2f89
1 parent a3d873e
commit 70f2f89
Show file tree

Hide file tree

Showing 6 changed files with 583 additions and 569 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/ruff/RUF052.py b/crates/ruff_linter/resources/test/fixtures/ruff/RUF052.py
@@ -1,4 +1,4 @@
-# Correct
+##################### Correct #####################
 
 for _ in range(5):
     pass
@@ -37,6 +37,17 @@ def fun():
     _x = "reassigned global"
     return _x
 
+# (we had a false positive when a global var is used like this in 2 functions)
+_num: int
+
+def set_num():
+    global _num
+    _num = 1
+
+def print_num():
+    print(_num)
+
+
 class _ValidClass:
     pass
 
@@ -70,7 +81,7 @@ def fun(x):
         return ___
     return x
 
-# Incorrect
+##################### Incorrect #####################
 
 class Class_:
     def fun(self):