fix(golang-rewrite): allow missing post-plugin-update callback during plugin update #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stratus3D
commented
Jan 23, 2025
Stratus3D
commented
- Remove incorrect breaking change from docs
- Handle missing post-plugin-update callback
Stratus3D
commented
Jan 23, 2025
| @@ -8,11 +8,6 @@ rather than a set of scripts. | |||
|
|
|||
| ## Breaking Changes | |||
|
|
|||
| ### `download` is now a required callback for plugins | |||
There was a problem hiding this comment.
Turns out I'd implemented things such that download is an optional callback. So this wasn't actually a change at all.
Stratus3D
force-pushed
the
tb/plugin-update-fixes
branch
from
bfc0762 to
aa0374a
Compare
… plugin update * Remove incorrect breaking change from docs * Handle missing post-plugin-update callback
Stratus3D
force-pushed
the
tb/plugin-update-fixes
branch
from
aa0374a to
7430db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.