Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Fix Partial Path Traversal Vulnerability #587

Commits on Jun 12, 2022

  1. Make plugin compatible with maven-site-plugin 4.0.0-M1 (asciidoctor#585)

    * Bump Doxia to 2.0.0-M1
    * Leave note in docs for release
    * Use SLF4J in site module (apache/maven-doxia#5)
    * Reorder constructor args in AsciidoctorDoxiaParserModule
    * Update IT test site.xml
    
    Fixes asciidoctor#578
    abelsromero authored Jun 12, 2022
    Configuration menu
    Copy the full SHA
    f76071a View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. vuln-fix: Partial Path Traversal Vulnerability

    This fixes a partial path traversal vulnerability.
    
    Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`.
    
    To demonstrate this vulnerability, consider `"/usr/outnot".startsWith("/usr/out")`.
    The check is bypassed although `/outnot` is not under the `/out` directory.
    It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object.
    For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`;
    however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`.
    
    Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')
    Severity: Medium
    CVSSS: 6.1
    Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.PartialPathTraversalVulnerability)
    
    Reported-by: Jonathan Leitschuh <[email protected]>
    Signed-off-by: Jonathan Leitschuh <[email protected]>
    
    Bug-tracker: JLLeitschuh/security-research#13
    
    Co-authored-by: Moderne <[email protected]>
    JLLeitschuh and TeamModerne committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    e720fca View commit details
    Browse the repository at this point in the history