Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 support #87

Merged
merged 16 commits into from
Mar 13, 2020
Merged

Angular 9 support #87

merged 16 commits into from
Mar 13, 2020

Conversation

smarlhens
Copy link
Collaborator

@smarlhens smarlhens commented Mar 13, 2020

Hey there,

I just updated ng-snotify to support Angular 6.1 to 9.x.

Semver

I matched ng-snotify version with Angular version :

  • 6.0.0 matches Angular 6.1.x
  • 7.0.0 matches Angular 7.2.x
  • 8.0.3 matches Angular 8.2.x
  • 9.0.0 matches Angular 9.x

Normally each version can be released by checking out the correct commit and building the library.

What's new

There are no breakings changes to report. I did the best I could with the use of semver. I made a lot of changes that improves, in my opinion, the maintainability and organization of the repository.
Here is the list of changes made (I didn't add them in the changelog because it doesn't concern the library):

v6.0.0

  • add Angular 6.1 support
  • bump ng-snotify version to match angular version
  • bump node-sass to 4.13.1
  • replace HttpModule with HttpClientModule
  • update dependencies

v7.0.0

  • add Angular 7.x support
  • bump ng-snotify version to match angular version
  • update dependencies

v8.0.0

  • add Angular 8.x support
  • bump ng-snotify version to match angular version
  • update dependencies
  • fix gulpfile.js by adding compiler-cli
  • remove redundant JSDoc

v8.0.1

  • add ci configuration with puppeteer
  • update karma, jasmine, protractor

v8.0.2

  • use ng-packagr instead of gulp to build library
  • change folder organization :
    • application: previously in example is now in the src folder
    • library: previously in src folder is now in the projects/ng-snotify
  • update angular.json file to match with new folder organization
  • add husky to manage git hooks easily (configuration file: .huskyrc)
  • add prettier to check and format the source code (configuration file: .prettierrc)
  • add lint-staged to run arbitrary scripts against currently staged files (configuration file: .lintstagedrc)
  • add commitizen which is a command line utility that makes it easier to create commit messages following the conventional commit format specification (configuration file: .czrc)
    Use git cz instead of git commit to use commitizen.
  • add commitlint to check if your commit messages meet the conventional commit format (configuration file: .commitlintrc)
  • update travis pipeline
  • reformat file names to match with kebab case
  • add cpx to copy assets (styles) in lib dist before packaging

v8.0.3

  • fix lib:build script

v9.0.0

  • add Angular 9.x support
  • bump ng-snotify version to match angular version
  • update dependencies
  • update ng-packagr configuration to copy assets
  • remove unused cpx dependency
  • fix sass files
  • add production configuration for ng-snotify library

Issues linked ?

Maybe the following issues will be resolved with this PR : #86 #85 #78 #68 #66

I you guys wanna try if my PR solves your issues :

  • clone from my fork smarlhens:ng-snotify
  • checkout the branch feature/ng-update for Angular 9 compatibility or check links in PR message above for another Angular version
  • run npm install
  • run npm run lib:build:prod
  • edit you application package.json and replace ng-snotify version with file:../ng-snotify/dist/ng-snotify/ng-snotify-9.0.0.tgz (or 8.0.3 or 7.0.0 or 6.0.0 depending which commit you cloned)
    Replace ../ with the path from your current folder to the ng-snotify cloned folder.
  • run npm install in your application folder
  • run and test your application

@artemsky artemsky merged commit 7d467fa into artemsky:master Mar 13, 2020
@artemsky
Copy link
Owner

@smarlhens Thank you so much! I'll publish new version later this day

@smarlhens smarlhens deleted the feature/ng-update branch March 13, 2020 14:52
@gitalvininfo
Copy link

Hi just a quick question. in changing the directory in package json, ng-snotify is currently on node_modules so the file path must be

file:node_modules/ng-snotify/dist/ng-snotify/ng-snotify-9.0.0.tgz.

still having an issue with ng snotify position. ive already posted. please let me know if i miss something.

Thank you

#angular9
#ng-snorify9. 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants