-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 9 support #87
Conversation
use ng-packagr instead of gulp; add prettier, lint-staged, husky, commitlint; update travis ci pipeline; refactor architecture to app & lib
@smarlhens Thank you so much! I'll publish new version later this day |
Hi just a quick question. in changing the directory in package json, ng-snotify is currently on node_modules so the file path must be file:node_modules/ng-snotify/dist/ng-snotify/ng-snotify-9.0.0.tgz. still having an issue with ng snotify position. ive already posted. please let me know if i miss something. Thank you #angular9 |
Hey there,
I just updated ng-snotify to support Angular 6.1 to 9.x.
Semver
I matched ng-snotify version with Angular version :
Normally each version can be released by checking out the correct commit and building the library.
What's new
There are no breakings changes to report. I did the best I could with the use of semver. I made a lot of changes that improves, in my opinion, the maintainability and organization of the repository.
Here is the list of changes made (I didn't add them in the changelog because it doesn't concern the library):
v6.0.0
HttpModule
withHttpClientModule
v7.0.0
v8.0.0
gulpfile.js
by adding compiler-cliv8.0.1
v8.0.2
example
is now in thesrc
foldersrc
folder is now in theprojects/ng-snotify
angular.json
file to match with new folder organization.huskyrc
).prettierrc
).lintstagedrc
).czrc
)Use
git cz
instead ofgit commit
to use commitizen..commitlintrc
)v8.0.3
lib:build
scriptv9.0.0
Issues linked ?
Maybe the following issues will be resolved with this PR : #86 #85 #78 #68 #66
I you guys wanna try if my PR solves your issues :
feature/ng-update
for Angular 9 compatibility or check links in PR message above for another Angular versionnpm install
npm run lib:build:prod
package.json
and replace ng-snotify version withfile:../ng-snotify/dist/ng-snotify/ng-snotify-9.0.0.tgz
(or8.0.3
or7.0.0
or6.0.0
depending which commit you cloned)Replace
../
with the path from your current folder to the ng-snotify cloned folder.npm install
in your application folder