Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify onRelease to not require suspend #3429

Merged
merged 2 commits into from
May 18, 2024

Conversation

kyay10
Copy link
Collaborator

@kyay10 kyay10 commented May 17, 2024

Not sure if we're doing PRs on main or arrow-2 now

@kyay10 kyay10 requested a review from nomisRev May 17, 2024 21:12
Copy link
Contributor

Kover Report

File Coverage [60.00%]
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt 60.00%
Total Project Coverage 57.78%

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @kyay10!

@nomisRev nomisRev merged commit 0e22aa3 into arrow-2 May 18, 2024
@nomisRev nomisRev deleted the kyay10/onRelease-without-suspend branch May 18, 2024 07:14
@nomisRev
Copy link
Member

We need to re-open this PR @kyay10. It was targeted at arrow-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants