Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode gptel model #21

Closed

Conversation

benthamite
Copy link

@benthamite benthamite commented Apr 23, 2024

Currently, when no model parameter is passed to consult-web--chatgpt-fetch-results, "gpt-3.5-turbo" is used. This pull request makes the function instead use the value of gptel-model, allowing the user to set the model to whichever one they have set in their gptel configuration.

@armindarvish
Copy link
Owner

@benthamite, Read the section about contributing:
https://github.com/armindarvish/consult-web?tab=readme-ov-file#contributions

I am using literate programming with one org file as the single source of truth. I cannot merge your pull request because it is not changing the org file! I implemented this in #22 and merged it in develop and main, and am closing your pull request. Next time, please change the org file and tangle it instead of directly editing the *.el files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants