Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore retry node when check succeeded descendant nodes. Fixes: #13003 #13004

Merged
merged 5 commits into from May 16, 2024

Conversation

shuangkun
Copy link
Member

ignore retry node when check descendant nodes.

Fixes #13003

Motivation

Modifications

Verification

@shuangkun shuangkun changed the title fix: ignore retry node when check descendant nodes. Fixes: #13003 fix: ignore retry node when check succeeded descendant nodes. Fixes: #13003 May 2, 2024
@agilgur5 agilgur5 added area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries area/retryStrategy Template-level retryStrategy labels May 2, 2024
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
workflow/util/util.go Outdated Show resolved Hide resolved
@Joibel Joibel self-assigned this May 7, 2024
Signed-off-by: shuangkun <[email protected]>
@shuangkun shuangkun force-pushed the fix/DeleteNodeBug branch 2 times, most recently from 3d532da to 629c0a3 Compare May 8, 2024 07:59
@shuangkun
Copy link
Member Author

/retest

1 similar comment
@shuangkun
Copy link
Member Author

/retest

Signed-off-by: shuangkun <[email protected]>
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrytangyuan terrytangyuan merged commit 71f1d86 into argoproj:main May 16, 2024
28 checks passed
@agilgur5 agilgur5 added this to the v3.5.x patches milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries area/retryStrategy Template-level retryStrategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows that failed before upgrade to 3.5.6 fail to retry
4 participants