New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing PR] test why e2e tests are failing #13002
Conversation
Rebased the branch to an earlier version of |
Hmm I thought it was #12736 as well due to a git blame I came upon. I suppose the quickest way to find out what the first offending commit is to git bisect. |
That uh assumes knowing a "good" commit, and I'm not sure which one is good 😬 Alan and I were thinking on Slack that it could potentially be an unpinned dep somewhere, though I couldn't pinpoint one that added up in the manifests. I was looking at the debug logs and wondering if the tests might be pulling |
Signed-off-by: Isitha Subasinghe <[email protected]>
Ok rebased once more to after #12917 annnd still same error. I chose that one as it was what #12926 was based on, which just merged (i.e. passed E2E on its own branch). So pretty sure it's not due to a commit at this point |
Noting here that the failing API test does result in a nil pointer dereference error in the Server logs:
|
I've managed to produce I can't see where the argocli image gets built and pushed during e2e, so I'll see if I can find a satisfactory fix for this. |
This is fixed in #13018 |
Thanks Alan for confirming my hypothesis and fixing the We should still pin all the other images in the test manifests too, to prevent a similar type of bug (or supply chain attack via tests) |
Fixes #TODO
Motivation
Modifications
Verification