fix(docs): Update buildkit example #12999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two issues with the current buildkit example: 1) The default branch is `master` but the argo-workflows repo only has `main` 2) The build task refers to a go project that no longer exists in this repo. To fix the issues: * I updated the default branch to `main` * I've removed the `build` step entirely. If preferred, I could modify the build step to use the example go project from that example workflow instead. Signed-off-by: Brandon High <[email protected]>
agilgur5
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Thanks for updating the outdated contents of this example!
I definitely missed main here in #12149, although GH should redirect the request such that it still works, did it not?
If preferred, I could modify the build step to use the example go project from that example workflow instead.
I think we do want to show a build step in this example for it to more closely resemble a standard build pipeline.
agilgur5
changed the title
agilgur5
added
the
problem/more information needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are two issues with the buildkit example: 1) The default branch is
masterbut the argo-workflows repo only hasmain2) The build task refers to a go project that no longer exists in this repo.Modifications
mainbuildstep entirely from the exampleIf preferred, I could modify the build step to use the example go project from that example workflow instead.
Verification
Ran the workflow from my local Argo workflows instance after setting up the Docker credentials as noted by the example.