fix: make sure we use the updated rs when we write back to informer (#…

…3237) Signed-off-by: Zach Aller <[email protected]>
argoproj · Dec 11, 2023 · a312af9 · a312af9
1 parent eaaef38
commit a312af9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/rollout/replicaset.go b/rollout/replicaset.go
@@ -34,7 +34,7 @@ func (c *rolloutContext) removeScaleDownDelay(rs *appsv1.ReplicaSet) error {
  return nil
  }
  patch := fmt.Sprintf(removeScaleDownAtAnnotationsPatch, v1alpha1.DefaultReplicaSetScaleDownDeadlineAnnotationKey)
- _, err := c.kubeclientset.AppsV1().ReplicaSets(rs.Namespace).Patch(ctx, rs.Name, patchtypes.JSONPatchType, []byte(patch), metav1.PatchOptions{})
+ rs, err := c.kubeclientset.AppsV1().ReplicaSets(rs.Namespace).Patch(ctx, rs.Name, patchtypes.JSONPatchType, []byte(patch), metav1.PatchOptions{})
  if err != nil {
  return fmt.Errorf("error removing scale-down-deadline annotation from RS '%s': %w", rs.Name, err)
  }