Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix excessive padding on system level extension pages (issue #17929) #18207

Conversation

david-wu-octopus
Copy link
Contributor

@david-wu-octopus david-wu-octopus commented May 14, 2024

Fixes #17929

This PR fixes a bug where system level extension pages have excessive left padding

Approach

Investigation

  • Per the original PR feat: system level extensions #10758 that added system level extensions, we know the current amount of left padding has deviated from the intended design. Originally, left padding was specified by the CSS class .cd-layout--extension
  • A subsequent PR feat: Page header and toolbar in system extensions #13451 wraps system level extensions in the <Page /> component. The <Page /> component applies the .sb-page-wrapper CSS class, which applies the same left-padding amounts as .cd-layout--extension
  • Therefore, the current amount of left padding is double the desired amount

Solution

  • Removed the CSS class .cd-layout--extension
  • Removed the isExtension prop of <Layout /> as it is no longer used anymore
  • Removed the extension property of type Routes in <App /> as it is also no longer used anymore

Results

Before

Sidebar open

image

Sidebar closed

image

After

Sidebar open

image

Sidebar closed

image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@david-wu-octopus david-wu-octopus requested a review from a team as a code owner May 14, 2024 05:01
@david-wu-octopus david-wu-octopus changed the title Fix excessive padding on system level extension pages (issue #17929) fix(ui): Fix excessive padding on system level extension pages (issue #17929) May 14, 2024
Signed-off-by: David Wu <[email protected]>
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @david-wu-octopus for the PR. LGTM!

@ishitasequeira ishitasequeira merged commit 22993de into argoproj:master May 20, 2024
24 checks passed
@david-wu-octopus david-wu-octopus deleted the fix-padding-on-system-level-extension-pages branch May 20, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding error with system level extensions
2 participants