Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update: ndarray. #546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

npatsakula
Copy link

@npatsakula npatsakula commented Dec 13, 2024

Plan

  • Cargo.toml update.
  • GitHub CI test suite update.

@npatsakula
Copy link
Author

Hi @stefan-k!

Can I ask you to take a look into this? Unfortunately, I can't even run a CI job here:(

@stefan-k
Copy link
Member

Hi @npatsakula , thank you for your contribution! :) For new contributors, the CI has to be started explicitly by me.
I'm afraid a proper review will have to wait until after the holidays du to other obligations :/ Apologies!

@stefan-k
Copy link
Member

stefan-k commented Jan 3, 2025

Hi @npatsakula , this looks good to me, any idea why the CI is failing? I suspect that you'll also have to update ndarray in crates/finitediff/Cargo.toml.

@amfaber
Copy link

amfaber commented Jan 4, 2025

Hello! I've touched up this PR in npatsakula#1
argmin-math was breaking since we were not aliasing the new "ndarray_0_16" to "ndarray". This fixes the nolinalg version, but ndarray-linalg still hasn't released a version thats compatible with 0.16 (rust-ndarray/ndarray-linalg#391) , so in order to fix that we need to wait for an upstream release.
The argmin-math tests complete successfully on my machine now, but argmin itself relies on the linalg version so thats still breaking

@stefan-k
Copy link
Member

stefan-k commented Jan 5, 2025

Thanks! Hopefully a new version of ndarray-linalg will be release soon and then we can merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants