[DO NOT MERGE] Dummy PR for test deltas report target #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
per1234
force-pushed
the
report-target-pr
branch
from
a9e0ba0
to
542649a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 745 745
=========================================
Hits 745 745 ☔ View full report in Codecov by Sentry. |
per1234
force-pushed
the
report-target-pr
branch
2 times, most recently
from
7d2850f
to
2b51c9a
Compare
|
Memory usage change @ 2b51c9a
Click for full report table
Click for full report CSV |
per1234
force-pushed
the
report-target-pr
branch
from
2b51c9a
to
4756532
Compare
|
Memory usage change @ 4756532
Click for full report table
Click for full report CSV |
|
Memory usage change @ 45a8dc9
Click for full report table
Click for full report CSV |
per1234
force-pushed
the
report-target-pr
branch
from
45a8dc9
to
189a8dd
Compare
|
Memory usage change @ 0123456789abcdef0123456789abcdef01234567
Click for full report table
Click for full report CSV |
|
Memory usage change @ 651f05f4d4aca30ac359e972c01568f873112d43
Click for full report table
Click for full report CSV |
|
Memory usage change @ 1c993a0
Click for full report table
Click for full report CSV |
per1234
force-pushed
the
report-target-pr
branch
from
1c993a0
to
f586e73
Compare
|
Memory usage change @ 651f05f4d4aca30ac359e972c01568f873112d43
Click for full report table
Click for full report CSV |
|
Memory usage change @ 0123456789abcdef0123456789abcdef01234567
Click for full report table
Click for full report CSV |
1 similar comment
|
Memory usage change @ 0123456789abcdef0123456789abcdef01234567
Click for full report table
Click for full report CSV |
|
Memory usage change @ 651f05f4d4aca30ac359e972c01568f873112d43
Click for full report table
Click for full report CSV |
per1234
force-pushed
the
report-target-pr
branch
from
35726ce
to
6b42ac6
Compare
|
Memory usage change @ 651f05f4d4aca30ac359e972c01568f873112d43
Click for full report table
Click for full report CSV |
|
Memory usage change @ 0123456789abcdef0123456789abcdef01234567
Click for full report table
Click for full report CSV |
|
Memory usage change @ 6b42ac6
Click for full report table
Click for full report CSV |
This sketches report artifact is used to get test size deltas reports.
…rkflow `actions/upload-artifact` is only bumped to v3 here because a significant change in the artifact format was introduced in 4.0.0. It is necessary for the workflow to continue to produce test data that provides integration test coverage for compatibility of the action with the artifacts produced by <=v3 of the action.
…name pattern feature The action was originally designed for a use case where there will only be a single sketches reports workflow artifact. Due to a change in the "actions/upload-artifact" GitHub Actions action, it became necessary to add the capability for the "arduino/report-size-deltas" action to be able to consume reports from multiple artifacts. The "Upload test sketches report artifact" GitHub Actions workflow is hereby updated to produce multiple test data artifacts in order to allow the "Run integration tests" workflow to provide coverage for the new capability. As was previously the case, one of the artifacts uploaded by the workflow contains multiple sketches report files in order to provide test data necessary to continue providing coverage for the <=actions/upload-artifact@v3 single artifact system. Even though the produced test data (multiple artifacts, with multiple reports in a single artifact) would not occur under real world usage, it is the cleanest way (the alternative being to create and maintain separate copies of the system implemented in the `report-target-pr` branch for each use pattern) to provide effective integration test coverage.
A significant change was made to the nature of GitHub Actions workflow artifacts starting from the 2.x release of the `@actions/artifact` package, which was introduced in the 4.0.0 release of the "actions/upload-artifact" GitHub Actions action. It is necessary to provide integration test coverage for compatibility of the "arduino/report-size-deltas" action with the v2 format artifacts produced by actions/upload-artifact@v4. It is also important to continue to cover compatibility with the v1 format artifacts produced by actions/upload-artifact@v3, to support users who have not gotten around to updating that action dependency in their sketch compilation workflows (especially since the breaking change introduced by actions/upload-artifact@v4 will make it necessary to adjust the configuration of the workflow). The chosen approach is to configure the "Upload test sketches report artifact" workflow to use actions/upload-artifact@v3 when upload one of the test data artifacts and actions/upload-artifact@v4 when uploading the other. Even though the produced test data would not occur under real world usage, it is the cleanest way (the alternative being to create and maintain separate copies of the system implemented in the `report-target-pr` branch for each major version of the actions/upload-artifact action) to provide effective integration test coverage.
per1234
force-pushed
the
report-target-pr
branch
from
6b42ac6
to
aa22d11
Compare
|
Memory usage change @ 0123456789abcdef0123456789abcdef01234567
Click for full report table
Click for full report CSV |
|
Memory usage change @ 651f05f4d4aca30ac359e972c01568f873112d43
Click for full report table
Click for full report CSV |
|
Memory usage change @ aa22d11
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sole purpose of this PR is to upload a "golden" sketches report artifact used in conjunction with the integration test workflow to get test size deltas reports in the comment thread in order to verify the functionality of the action.
The size deltas report should match the following:
Memory usage change @ 2b51c9a
arduino:avr:leonardoarduino:sam:arduino_due_xarduino:samd:mkrzeroClick for full report table
examples/MIDIUSB_clockflash
examples/MIDIUSB_clockRAM for global variables
examples/MIDIUSB_loopflash
examples/MIDIUSB_loopRAM for global variables
examples/MIDIUSB_readflash
examples/MIDIUSB_readRAM for global variables
examples/MIDIUSB_writeflash
examples/MIDIUSB_writeRAM for global variables
arduino:avr:leonardoarduino:sam:arduino_due_xarduino:samd:mkrzeroClick for full report CSV