Fix firmware info (#492)

* fix get firmware info * 2.4.7
arduino · Apr 27, 2021 · 2f0e02f · 2f0e02f
1 parent f22498b
commit 2f0e02f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "arduino-create-agent-js-client",
-  "version": "2.4.6",
+  "version": "2.4.7",
   "description": "JS module providing discovery of the Arduino Create Plugin and communication with it",
   "main": "lib/index.js",
   "module": "es/index.js",

diff --git a/src/firmware-updater.js b/src/firmware-updater.js
@@ -91,15 +91,15 @@ export default class FirmwareUpdater {
           if (!this.firmwareVersionData) {
             this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't get firmware info: couldn't find version '${firmwareVersion}' for board '${boardId}'` });
           }
+          else {
+            firmwareInfoMessagesSubscription.unsubscribe();
+            this.updating.next({ status: this.updateStatusEnum.GOT_INFO });
+          }
           break;
         case 'Error':
           this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Couldn't get firmware info: ${message.Msg}` });
           firmwareInfoMessagesSubscription.unsubscribe();
           break;
-        case 'Done':
-          firmwareInfoMessagesSubscription.unsubscribe();
-          this.updating.next({ status: this.updateStatusEnum.GOT_INFO });
-          break;
         default:
           break;
       }