Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseIn() pullup/down comment #538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

russmcinnis
Copy link
Contributor

There is a situation where using pulseIn() on a pin that has a floating voltage could cause a sketch to hang at the pulseIn() function call. A comment was added to the pulseIn() function header to use a pull up or pull down resistor.

@russmcinnis
Copy link
Contributor Author

@SidLeung please review.

Copy link
Contributor

@eriknyquist eriknyquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @SidLeung to review also

@kitsunami kitsunami removed this from the Bootes milestone Aug 30, 2017
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants