Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example usage of useTranslation inside generateMetadata #1199

Merged
merged 4 commits into from
Mar 21, 2024
Merged

example usage of useTranslation inside generateMetadata #1199

merged 4 commits into from
Mar 21, 2024

Conversation

huseyinonalcom
Copy link
Contributor

@huseyinonalcom huseyinonalcom commented Mar 20, 2024

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

Added example usage of useTranslation inside generateMetadata in the app router example.

What changes did you make? (Give an overview)

Added a single new translation to each of the locales in the example and added generateMetadata in the second page with usage of useTranslation.

Which issue (if any) does this pull request address?

Makes the app router example a bit more comprehensive.

Is there anything you'd like reviewers to focus on?

None

Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @huseyinonalcom

@aralroca aralroca merged commit 335c039 into aralroca:canary Mar 21, 2024
6 checks passed
@aralroca
Copy link
Owner

@all-contributors please add @huseyinonalcom for code

Copy link
Contributor

@aralroca

I've put up a pull request to add @huseyinonalcom! 🎉

aralroca pushed a commit that referenced this pull request Mar 21, 2024
* added second-page-title to locales/ca/common.json

* added second-page-title to locales/es/common.json

* added second-page-title to locales/en/common.json

* added generateMetadata with usage of useTranslation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants