Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when clean up scripts run #1132

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

crs1138
Copy link
Contributor

@crs1138 crs1138 commented Aug 14, 2023

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
The clean up scripts were relying on the shells rm -rf command which was causing to fail when the files matching the pattern were missing. I've replaced this with the del-cli node package that ignores those missing files.

Which issue (if any) does this pull request address?
This is addressing #891

Is there anything you'd like reviewers to focus on?

Details:
---
* The clean up scripts were relying on the shells `rm -rf` command which
  was causing to fail when the files matching the pattern were missing.
  I've replaced this with the `del-cli` node package that ignores those
  missing files.
Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@aralroca
Copy link
Owner

@all-contributors please add @crs1138 for maintenance

@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @crs1138! 🎉

@aralroca aralroca merged commit eaac14f into aralroca:master Aug 14, 2023
6 checks passed
crs1138 added a commit to crs1138/next-translate that referenced this pull request Aug 16, 2023
…-locale-from

* 'master' of github.com:aralroca/next-translate:
  Fix error when clean up scripts run (aralroca#1132)
  docs: add crs1138 as a contributor for maintenance (aralroca#1134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants