Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repo and snapshots packages filter api add 'maximumVersion' que… #1088

Conversation

hudeng-go
Copy link
Contributor

repo and snapshots packages filter api add 'maximumVersion' query parameter support

@randombenj randombenj self-requested a review June 22, 2022 09:09
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.04%. Comparing base (b3d9055) to head (b3dd947).
Report is 116 commits behind head on master.

Current head b3dd947 differs from pull request most recent head 2e7f501

Please upload reports for the commit 2e7f501 to get more accurate results.

Files Patch % Lines
api/api.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1088       +/-   ##
===========================================
- Coverage   66.30%   52.04%   -14.27%     
===========================================
  Files         141       73       -68     
  Lines       15908    11281     -4627     
===========================================
- Hits        10548     5871     -4677     
- Misses       4610     4846      +236     
+ Partials      750      564      -186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randombenj
Copy link
Contributor

Could you please add a test for the suggested changes?

…ry parameter support

example: `curl http://localhost:8080/api/repos/test/packages\?maximumVersion\=1`

Change-Id: Ie9ffd36146bf017bbb353737f32360f7b73d6b0a
@hudeng-go hudeng-go force-pushed the add-maximumVersion-filter-support branch from b3dd947 to 2e7f501 Compare August 30, 2022 07:36
@goldendeng
Copy link

Could you please add a test for the suggested changes?

Added an API test.

@neolynx
Copy link
Member

neolynx commented Jun 15, 2024

continued in #1301

@neolynx neolynx closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants