-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding authorisation options for API access #1042
base: master
Are you sure you want to change the base?
Conversation
I went through the failing tests, and unless I'm missing something, those are not from my changes, not sure what I can do about that short of refactoring someone else's code. I'm happy to muck around if needed, but you'd likely prefer someone with a lot more chops than myself to mitigate those issues. |
@bpiraeus It looks like mostly deprecation errors
If you want to, feel free to investigate if there are some simple fixes for the deprecated packages (x/term) seems to be quite an easy one, not sure about the crypto one ... |
Cleaned up a few oddballs in my code that gosimple flagged, also moved the terminal bits to the appropriate package, the pgp ones appear as if they're likely going to want 3rd party library. |
introducing authorization per repo is a nice idea. however, authentication without SSL is not that nice, so probably we should implement this as well with this change. since different authentication types are supported, the variable |
7291b04
to
888025c
Compare
rebased on master |
- ldap currently the only supported method adding authorisation options for local repositories - ldap groups per repo
888025c
to
ef42975
Compare
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Checklist
AUTHORS