Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Custom date selector UI #79

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Custom date selector UI #79

wants to merge 6 commits into from

Conversation

prajwalkulkarni
Copy link
Contributor

💫 Changelog

⭐ Adds Custom date range selector - UI changes

@prajwalkulkarni prajwalkulkarni marked this pull request as draft February 29, 2024 17:23
@prajwalkulkarni prajwalkulkarni marked this pull request as ready for review April 11, 2024 15:44
@prajwalkulkarni
Copy link
Contributor Author

Hey @goenning I've made the suggested changes for the UI part, the updated date selector looks fine on smaller screens
aptabase-date

Currently, I'm not passing the granularity value to trackEvent or anywhere else, is it something that should be returned by the useDatePicker hook? Could you please tell me its use case with the updated UI(custom date selector)? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prajwalkulkarni