Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new country Palestine with its translations #8031

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add new country Palestine with its translations #8031

wants to merge 10 commits into from

Conversation

xuelink
Copy link
Contributor

@xuelink xuelink commented Apr 26, 2024 •
edited

What does this PR do?

This PR adds a new country to the locale endpoint, providing all the necessary translations.

Fixes #8003

Test Plan

Github Action will test the new country.

Screenshot 2024-04-27 at 1 40 26 AM Screenshot 2024-04-27 at 1 40 38 AM Screenshot 2024-04-27 at 1 40 11 AM

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@xuelink xuelink changed the title Feat 8003 missing country for locale endpoint Palestine Add new country Taiwan with its translations Feat 8003 Add new country Palestine with its translations Apr 26, 2024
@xuelink xuelink changed the title Feat 8003 Add new country Palestine with its translations Add new country Palestine with its translations Apr 26, 2024
@stnguyen90 stnguyen90 self-requested a review April 30, 2024 04:27
stnguyen90
stnguyen90 requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing locale tests.

@xuelink
Copy link
Contributor Author

xuelink commented May 5, 2024

Please fix failing locale tests.

@stnguyen90 You can run this test again, i just fixed and committed for failing test.

@stnguyen90 stnguyen90 self-requested a review May 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 Awaiting requested review from stnguyen90

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Enhancement: Missing Country for Locale endpoint -- Palestine
2 participants
@xuelink @stnguyen90