Read 20MBs but send response in chunks of 2MB #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $bytesToRead = min(APP_STORAGE_READ_BUFFER, $size - $bytesRead); | ||
|
|
||
| // Read data from the device and append to the buffer | ||
| $buffer .= $deviceFiles->read($path, $bytesRead, $bytesToRead); |
There was a problem hiding this comment.
I don't think we should append to buffer, because this means by the end whole file in the memory, and this logic is to prevent exactly that. Just keep the recent chunk in the buffer
There was a problem hiding this comment.
We are not appending the entire file to the buffer. If you look at the loop below, we remove each chunk from the buffer after processing.
// Remove the sent chunk from the buffer
$buffer = substr($buffer, MAX_OUTPUT_CHUNK_SIZE);
There was a problem hiding this comment.
Why do this, why not instead of $buffer .= $deviceFiles->read($path, $bytesRead, $bytesToRead); simply use $buffer = $deviceFiles->read($path, $bytesRead, $bytesToRead); and when loop ends simply $buffer = null. The substr adds more processing
lohanidamodar
requested changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The code efficiently reads data in chunks of APP_STORAGE_READ_BUFFER size and sends it in chunks of MAX_OUTPUT_CHUNK_SIZE, optimizing the transfer process for large files.
Test Plan
Tested using node SDK. Download time went down
4xfrom 68528ms to 25188ms.Related PRs and Issues
Checklist