Prevent functions domain to be used as custom domain #7934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
May 2, 2024
app/controllers/api/proxy.php
Outdated
| @@ -49,6 +49,12 @@ | |||
| if ($domain === $mainDomain) { | |||
| throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, 'You cannot assign your main domain to specific resource. Please use subdomain or a different domain.'); | |||
| } | |||
|
|
|||
| $functionsDomain = App::getEnv('_APP_DOMAIN_FUNCTIONS', ''); | |||
There was a problem hiding this comment.
Should we do the same for regular custom domains? or this is taking care of this and the error message can be more accurate?
There was a problem hiding this comment.
I don't understand what you mean?
eldadfux
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevent functions domain to be used as custom domain
Test Plan
Manually tested
Related PRs and Issues
Checklist