Add Sendable to FileRuleDescription #7563
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, the same changes are included in #7559 |
|
We haven't added sendable annotations on most of SwiftPM right now. Happy to have them added piecemeal, but could you add to |
MaxDesiatov
previously approved these changes
May 28, 2024
MaxDesiatov
dismissed
their stale review
Just noticed this was filed against release/6.0. It has to land in main first.
giginet
requested review from
jakepetroules,
francescomikulis and
xedin
as code owners
|
I changed the base to main |
|
@swift-ci test |
MaxDesiatov
added
concurrency
no functional change
|
@swift-ci test windows |
jakepetroules
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I found that the
FileRuleDescriptiondoesn't conform toSendable; due to this, some products fail to build for Swift 6.Modifications:
Some structs conform to
SendableResult:
I passed to build on the latest Swift 6.0 snapshot.