Refactor message-passing logic into pkl-core #640
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HT154
force-pushed
the
refactor-messaging-into-core
branch
2 times, most recently
from
9a66edc
to
12c5461
Compare
HT154
commented
Sep 9, 2024
| } else { | ||
| val in1 = PipedInputStream() | ||
| val out1 = PipedOutputStream(in1) | ||
| val in2 = PipedInputStream() | ||
| val out2 = PipedOutputStream(in2) | ||
| MessageTransports.stream(in1, out2) to MessageTransports.stream(in2, out1) | ||
| Pair.of( |
There was a problem hiding this comment.
This is using org.pkl.core.util.Pair instead of Kotlin's Pair now that it's implemented in Java since the API's similar enough to work as a drop-in. Let me know if there's something different I should do!
HT154
force-pushed
the
refactor-messaging-into-core
branch
2 times, most recently
from
bf521a3
to
db5e090
Compare
This is preparatory work for [SPICE-0009](apple/pkl-evolution#10). It is being contributed in a separate pull request to ease review. The Message, Message(En|De)coder, and MessageTransport types have been ported to Java and moved to a new `org.pkl.core.messaging` package.
HT154
force-pushed
the
refactor-messaging-into-core
branch
6 times, most recently
from
25b7e66
to
33ffac8
Compare
HT154
force-pushed
the
refactor-messaging-into-core
branch
from
33ffac8
to
2ea97a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory work for SPICE-0009. It is being contributed in a separate pull request to ease review.
The Message, Message(En|De)coder, and MessageTransport types have been ported to Java and moved to a new
org.pkl.core.messagingpackage.