feat: pass detached option in exec #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also add it to the documentation? |
mykola-mokhnach
approved these changes
Oct 11, 2019
| cwd: opts.cwd, | ||
| env: opts.env, | ||
| shell: opts.shell, | ||
| detached: opts.detached, |
There was a problem hiding this comment.
detached processes should never use STDIO, can it be the case here?
There was a problem hiding this comment.
Can it be the case that they use stdio? In general? Most likely.
In the particular case I currently need it? No.
KazuCocoa
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass through the detached option to
child_process.spawninsideexec.This, at the very least, will allow us to bypass the error currently happening where
idb killkills the process (and, because they are attached, the appium process).See appium/appium-idb#18