chore: Optimize streaming processing and history #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
reviewed
Jun 28, 2024
| @@ -170,31 +153,6 @@ class SubProcess extends EventEmitter { | |||
|
|
|||
| // emit the actual output for whomever's listening | |||
| this.emit('output', stdout, stderr); | |||
|
|
|||
| // we also want to emit lines, but it's more complex since output | |||
There was a problem hiding this comment.
so we just don't need this logic anymore? how come?
There was a problem hiding this comment.
it's still there, just based on a different foundation to save CPU and memory. Tests remain unchanged and the logic is preserved
KazuCocoa
approved these changes
Jun 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2024
## [2.1.7](v2.1.6...v2.1.7) (2024-06-29) ### Miscellaneous Chores * Optimize streaming processing and history ([#435](#435)) ([b63798e](b63798e))
|
🎉 This PR is included in version 2.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.