Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable strict packages locking #412

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

No description provided.

@mykola-mokhnach mykola-mokhnach merged commit c622083 into appium:main Dec 7, 2023
5 checks passed
@mykola-mokhnach mykola-mokhnach deleted the no_lock branch December 7, 2023 23:08
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
## [2.1.0](v2.0.112...v2.1.0) (2023-12-07)

### Features

* Disable strict packages locking ([#412](#412)) ([c622083](c622083))
Copy link

github-actions bot commented Dec 7, 2023

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eglitise
Copy link

eglitise commented Dec 8, 2023

I wonder if the change for dropping Node 14 should be reverted for now. Appium uses teen_process in many places (including the core appium package), and it still supports (or at least should support) Node 14.
Though I'm not sure what the current behavior is - I guess npm would simply throw the EBADENGINE warning on install, but all functionality would still work fine?

@mykola-mokhnach
Copy link
Contributor Author

Though I'm not sure what the current behavior is - I guess npm would simply throw the EBADENGINE warning on install, but all functionality would still work fine?

Yes, this is how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants