Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing integrity hashes to npm lockfile #19630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NyCodeGHG
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

npm has a really annoying bug where integrity hashes don't get stored in the lockfile. See npm/cli#4460

For downstream packaging in nixpkgs we need these hashes and we would prefer to upstream this change.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

linux-foundation-easycla bot commented Jan 9, 2024

CLA Not Signed

@github-actions github-actions bot added chore refactoring, overhead, tests, etc. Dependencies issues with dependencies labels Jan 9, 2024
@NyCodeGHG NyCodeGHG marked this pull request as draft January 9, 2024 11:28
@jlipps
Copy link
Member

jlipps commented Jan 10, 2024

Thanks @NyCodeGHG. What's the mechanism by which you brought these fields back into package-lock?

@NyCodeGHG
Copy link
Author

@jlipps i used this tool: https://github.com/jeslie0/npm-lockfile-fix
I marked the PR as a draft because I still had some issues with building appium in nixpkgs and I still have to clarify stuff regarding the CLA with my employer.

@NyCodeGHG NyCodeGHG marked this pull request as ready for review February 5, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore refactoring, overhead, tests, etc. Dependencies issues with dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants