-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump targetSdkVersion to 33 #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shall we change the parent class to call the clearCache method for higher Android APIs as adviced above? |
Yeah, I figured out how to call that. I have tested the condition with Android 14 with page source, find element and send keys. It worked, so I hope this won't break other functionalities... |
mykola-mokhnach
approved these changes
Dec 29, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
## [5.15.0](v5.14.0...v5.15.0) (2023-12-29) ### Features * bump targetSdkVersion to 33 ([#583](#583)) ([25e9868](25e9868))
🎉 This PR is included in version 5.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Update]:
Below one has been resolved by calling
Build.VERSION_CODES.TIRAMISU
condition withaccessibilityService.clearCache();
While existing method works with Android 14, probably the recommended way will be safe.[Original]
One concern is https://developer.android.com/about/versions/13/changes/non-sdk-13#new-blocked
appium-uiautomator2-server/app/src/main/java/io/appium/uiautomator2/utils/AXWindowHelpers.java
Lines 50 to 51 in 1a1d473
i have tested the code with Android 13 and Android 14 by adding
Logger.info("Calling UiAutomatorBridge.getInstance().getUiAutomation().setServiceInfo(null);");
before theUiAutomatorBridge.getInstance().getUiAutomation().setServiceInfo(null);
call. Then, likedriver.page_source
and find element printed logs as below and they worked without issue. Thus I think it should not be our concern for now.