feat: add snapshotMaxDepth to be able to detect deep depth elements #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/io/appium/uiautomator2/core/AxNodeInfoHelper.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/appium/uiautomator2/model/settings/SnapshotMaxDepth.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/appium/uiautomator2/model/settings/SnapshotMaxDepth.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| protected void apply(Integer value) { | ||
| if (value == null || value < 10 || value > 200) { |
There was a problem hiding this comment.
Please move min and max values to constants. I would also think about making it more flexible, for example 1..500
mykola-mokhnach
approved these changes
Jun 20, 2023
|
Thanks. Please create one more PR to https://github.com/appium/appium-uiautomator2-driver afterwards to document the newly added setting |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
## [5.12.0](v5.11.1...v5.12.0) (2023-06-20) ### Features * add snapshotMaxDepth to be able to detect deep depth elements ([#517](#517)) ([9a40742](9a40742))
|
🎉 This PR is included in version 5.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks! I created the PR. appium/appium-uiautomator2-driver#629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
snapshotMaxDepthsetting API to be able to detect deep depth elements. Added this parameter as setting API as same as appium-xcuitest-driverissue #516