fix(web): drs breaking due to infinite props updates (#2190)

* fix(web): drs breaking due to infinite props updates * v3.43.9-alpha.1 * v3.43.9-alpha.2 * fix(web): sync reactivecore
appbaseio · Mar 14, 2023 · fb274f3 · fb274f3
1 parent 259626f
commit fb274f3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/packages/reactivecore b/packages/reactivecore
diff --git a/packages/web/src/components/range/DynamicRangeSlider.js b/packages/web/src/components/range/DynamicRangeSlider.js
@@ -226,9 +226,14 @@ class DynamicRangeSlider extends Component {
 			this.setReact(this.props);
 		});
 
-		checkSomePropChange(this.props, prevProps, ['dataField', 'nestedField', 'aggregationSize'], () => {
-			this.updateRangeQueryOptions(this.props);
-		});
+		checkSomePropChange(
+			this.props,
+			prevProps,
+			['dataField', 'nestedField', 'aggregationSize'],
+			() => {
+				this.updateRangeQueryOptions(this.props);
+			},
+		);
 
 		checkSomePropChange(
 			this.props,
@@ -629,7 +634,12 @@ class DynamicRangeSlider extends Component {
 	}
 
 	render() {
-		if (!this.state.currentValue || !this.state.range || this.props.range.start === null) {
+		if (
+			!this.state.currentValue
+			|| !this.state.range
+			|| this.props.range === null
+			|| this.props.range.start === null
+		) {
 			return null;
 		}
 
@@ -785,6 +795,10 @@ const mapStateToProps = (state, props) => {
 	}
 	if (range) {
 		range = formatRange(range);
+		// eslint-disable-next-line no-restricted-globals
+		if (isNaN(range.start) && isNaN(range.end)) {
+			range = null;
+		}
 	}
 	return {
 		options,