-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mocks for a basic set of operations to work with GraphOS demo #94
Conversation
we need graph id to make identifier unique
Based on ad-blockers and the modern internet, we can't rely on referrer to uniquely identify demos and make the mocked data work independently from each other
More mocks will need to be added in the future with additional tests
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Will be nice to be able to try out the API without the token. Appreciate you putting this in there!
The biggest thing I could see as a potential pitfall is the sharing of the mocks
object between all users, which would clobber each other's state.
…g existing object
…to guarantee state creation. Use this.state everywhere and remove conditional checks on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the parts I was concerned with myself. Feel free to take or leave the rest of the non-resolved feedback from my last review!
…/spotify-showcase into mock-subscriptions
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
No description provided.