Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced signature generation #5153

Merged
merged 48 commits into from
Jun 12, 2024
Merged

Enhanced signature generation #5153

merged 48 commits into from
Jun 12, 2024

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented May 13, 2024

Adds a new experimental configuration to support enhanced signature generation. The changes are:

Remove some hacks and quirks of the JS implementation related to properly sorting everything and using commas vs spaces
Includes aliases in the signature
Includes the full normalized form of input objects
Fixes ROUTER-262
Replaces PR #5062

To get this over the line the tests need a little refactoring to use insta and maybe Asset to allow easy addition of new tests.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@router-perf
Copy link

router-perf bot commented May 13, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@bonnici bonnici mentioned this pull request May 30, 2024
6 tasks
@bonnici
Copy link
Contributor

bonnici commented May 30, 2024

I've addressed the PR comments but I don't have access to push to this branch/PR. I made a new branch/PR but it's based on the latest dev code so there are some unrelated changes in the PR. If this branch is synced with dev I think the PR should look a lot cleaner.

#5285

@Geal
Copy link
Contributor

Geal commented May 31, 2024

I just merged dev in both branches and solved conflicts, #5285 looks much smaller now

@bonnici bonnici requested review from a team as code owners June 3, 2024 00:45
@bonnici
Copy link
Contributor

bonnici commented Jun 3, 2024

I've merged #5285 into this branch now and addressed the remaining PR comments.

Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple formatting suggestions. Changes look good, I think

apollo-router/src/apollo_studio_interop/mod.rs Outdated Show resolved Hide resolved
apollo-router/src/apollo_studio_interop/mod.rs Outdated Show resolved Hide resolved
apollo-router/src/apollo_studio_interop/mod.rs Outdated Show resolved Hide resolved
@bonnici bonnici merged commit e85a606 into dev Jun 12, 2024
14 checks passed
@bonnici bonnici deleted the njm/P-695/sig-gen-algo branch June 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants